Integrate pallet-fixed-validators-set#1618
Merged
Conversation
9963ac7 to
bc864c6
Compare
5fa9eb4 to
88f4b90
Compare
a3f2faa to
319084c
Compare
319084c to
a15fec9
Compare
88f4b90 to
040c810
Compare
quasiyoke
approved these changes
Oct 7, 2025
a15fec9 to
57d1447
Compare
Contributor
Author
|
I have updated the PR description with some notes on the intent for this change. Also, I'm tempted to postpone the complete testing coverage of this feature for a less urgent moment; please give me your opinion on what it critical to test in this high-urgency timing, and what we could test later. I, for one, think we should add tests to see to it that the |
b780da5 to
cc5f24c
Compare
Contributor
Author
|
I've added the test I wanted and it turns out there is an issue there! I've decided to provide a separate PR for the fix: #1621 |
324db2b to
753c3d0
Compare
…est (#1620) Add more checks to verify slashin logic at a corresponding runtime test
* Add dedupe utils * Implement validator deduplication based on account id and the first-in order * Fix the doc comment on the DedupeKeyExtractor::Output * Fixed doc comment on DedupeIter::dedupe_key_extractor * Apply suggestion from @dmitrylavrenov Co-authored-by: Dmitry Lavrenov <39522748+dmitrylavrenov@users.noreply.github.com> * Add a test * Remove the broken impl (doesn't work either way) --------- Co-authored-by: Dmitry Lavrenov <39522748+dmitrylavrenov@users.noreply.github.com>
753c3d0 to
b4369af
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a continuation of #1617. Here we integrate the fixed validators set with the humanode session, humanode offences, runtime, peer and etc.
Feel free to note what's needed to be done here with regard to Q/A - like more tests or benches.
The intended design: